Skip to content

Add currency selector in Pay UI #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 11, 2024
Merged

Add currency selector in Pay UI #3251

merged 11 commits into from
Jun 11, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jun 10, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR allows users to select fiat currencies in the Pay UI.

Detailed summary

  • Added support for selecting fiat currency in Pay UI
  • Expanded fiat currency options to include CAD, GBP, and EUR
  • Updated currency selection components and functions
  • Improved user interface for currency selection in the Buy screen

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@MananTank MananTank requested a review from IDubuque as a code owner June 10, 2024 16:25
@linear
Copy link

linear bot commented Jun 10, 2024

CNCT-1344 Enable selecting currency in thirdweb pay ui

@vercel
Copy link

vercel bot commented Jun 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 3:58pm

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 62bb68d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3251 will not alter performance

Comparing cnct-1344 (62bb68d) with main (923a5ec)

Summary

✅ 9 untouched benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.33 KB (0%) 807 ms (0%) 3.2 s (+8.06% 🔺) 4 s
thirdweb (cjs) 90.06 KB (0%) 1.9 s (0%) 6.5 s (-0.34% 🔽) 8.3 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 590 ms (+257.94% 🔺) 685 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 110 ms (+117.35% 🔺) 120 ms
thirdweb/react (minimal + tree-shaking) 15.74 KB (0%) 315 ms (0%) 296 ms (-40.42% 🔽) 611 ms

@MananTank MananTank enabled auto-merge June 11, 2024 14:08
@MananTank MananTank added this pull request to the merge queue Jun 11, 2024
@codecov
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 49 lines in your changes missing coverage. Please review.

Project coverage is 63.28%. Comparing base (d2cbb1e) to head (62bb68d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
+ Coverage   63.26%   63.28%   +0.01%     
==========================================
  Files         833      835       +2     
  Lines       63328    63507     +179     
  Branches     3433     3433              
==========================================
+ Hits        40066    40191     +125     
- Misses      22587    22641      +54     
  Partials      675      675
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from d2cbb1e
packages 62.80% <22.22%> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/thirdweb/src/pay/buyWithFiat/getQuote.ts 83.27% <100.00%> (-0.12%) ⬇️
...b/ui/ConnectWallet/screens/Buy/fiat/currencies.tsx 74.54% <66.66%> (ø)
...ui/ConnectWallet/screens/Buy/PayWIthCreditCard.tsx 25.25% <0.00%> (+0.98%) ⬆️
...nectWallet/screens/Buy/fiat/FiatTxDetailsTable.tsx 16.66% <33.33%> (+0.11%) ⬆️
...ectWallet/screens/Buy/main/useUISelectionStates.ts 16.32% <0.00%> (-0.52%) ⬇️
...thirdweb/src/react/web/ui/components/TokenIcon.tsx 38.46% <20.00%> (-1.13%) ⬇️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 10.43% <5.26%> (-0.04%) ⬇️
...nnectWallet/screens/Buy/fiat/CurrencySelection.tsx 23.43% <30.76%> (ø)

... and 4 files with indirect coverage changes

Merged via the queue into main with commit ce45a79 Jun 11, 2024
@MananTank MananTank deleted the cnct-1344 branch June 11, 2024 16:03
@jnsdls jnsdls mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@IDubuque IDubuque Awaiting requested review from IDubuque

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MananTank @joaquim-verges @gregfromstl